search

DH-IT-Portal-Development / ethics

Ethical Committee web application in Django
http://fetc.hum.uu.nl
MIT License
2 stars 1 forks source link

Members: editing of comments #638

Closed djhcapel closed 2 months ago

djhcapel commented 3 months ago

In the LC, some of us remembered being able to edit comments. This does not seem possible anymore. One of us inadvertently pressed 'Enter' halfway a sentence, and could not undo that anymore. Could an editing option be re-installed? Or incorporated? Perhaps with a tick that a comment is ready?

miggol commented 3 months ago

Short term because this used to be possible, so if we can easily reinstate that feature then great.

However, if it turns out that this feature was removed because of some kind of complexity or bug, this can be moved to the "long term" milestone.

tymees commented 3 months ago

The problem was introduced here: https://github.com/DH-IT-Portal-Development/ethics/commit/c7e2fedc53fdec51c7a5b30be9b737094f2d7641

The first change was restoring old behaviour, it always locked the option after all comments where in (I checked against the v2 tag). The second change locks a decision after a go/no-go is set, which was not in the pre-review-actions code.

miggol commented 3 months ago

Well found, Ty.

@djhcapel We'll restore the old behaviour for now: anyone can edit their feedback unless they were the final reviewer and the review enters the "To conclude" stage.