search

DH-IT-Portal-Development / ethics

Ethical Committee web application in Django
http://fetc.hum.uu.nl
MIT License
2 stars 1 forks source link

Fix/bugfix and textual changes #643

Closed EdoStorm96 closed 3 months ago

EdoStorm96 commented 3 months ago

Fixes #634, #641 and #642.

642 and #643 are textual changes. #641 was a bug caused by an incorrect refactor, when changing the choices to model choices ... The labels for the two different options in PracticeReasons were switched around ... my bad ;p

EdoStorm96 commented 3 months ago

I have also just included a fix for #624. This just adds proposal.date_reviewed to the "Continuation:" section of review_detail_sidebar.html.

EdoStorm96 commented 3 months ago

Decided to just push on more fix to this branch, as it was also a textual change. this fixes #608. Now I will leave this PR alone, haha. Could you have one more look, @tymees? :innocent:

tymees commented 3 months ago

Ehhh, I'm not great at reviewing these textual changes. I'm kinda word-blind remember?

The only check I would do is seeing if the translations apply correctly, but I trust you to have tested that ;)

If you really want me to make a comment, there's some junk gathering at the end of the .po file (due to outdated translations being moved there automatically). It's a pet-peeve of mine, but not a problem ;)