DH-IT-Portal-Development / ethics

Ethical Committee web application in Django
http://fetc.hum.uu.nl
MIT License
2 stars 1 forks source link

Break up page 1 #654

Open tymees opened 3 months ago

tymees commented 3 months ago

Page 1 of the form is... not great. I hate the UX, and that's actually going to be worse in the new design (as it takes up way more space). On the code side, I think it's the largest form we currently have, which brings a lot of complexity and general 'weirdness'. (Btw, I checked, that page does at least 20 calls to the backend due to js-check-storm).

So, I want to break up that entire form/pages into separate forms/pages. I think the most logical approach would be to, in general, follow the proc.reg. structure. (Steps 1 through 3).

Currently, the page is like so: (nested questions are depending on the one above)

Following the procreg design, you'd arrive at the following distribution:

Preable:

Page 1: "De studie"

Sub-page 1 (not-in-procreg) 'Relatie'

Sub-page 2 "Mede onderzoekers"

Note: I'm not entirely sure stakeholders isn't in procreg... It feels eerily similar to step 7 'ontvangers', but that's a lot more structured

Sub-page 3: "faculteit"

Empty, we only have humanities. This page could also house the 'institution' question? I'm mostly listing it because REBO has been grumbling about our ethics portal for some time, without any clear plan...

Page 2: "Studieperiode"

Page 3: "Onderzoeksdoel"

Page 4: not in procreg. 'Funding'

This leaves the pre-approved questions dangling. They should probably be their own main page, inserted somewhere between the pages above (Page 5?)

miggol commented 2 months ago

I'm not so set on aligning the order of questions with procreg as an ideal. But it's as good as starting point as any.

My comments:

tymees commented 2 months ago

About your first few points; I think they make sense, if you indeed want to drop the procreg-commonality. But I think that's a decision our secretary should say something about one way or the other.

But I do agree that placing funding near the stakeholders makes a ton of sense. My only worry would be the amount of questions on said page, but that's something we can just try out at first

EdoStorm96 commented 2 months ago

I also mostly agree with the ideas outlined so far here. I guess funding getting moved to Subpage 2 "Mede-onderzoekers" is not so bad, if supervisor gets moved to Subpage 1 "Relatie". However, then subpage 1 gets kindoff big, especially for students. But maybe we can move institution up to Page 1 "De Studie"? This page would then include title, date start and institution, which imho kinda makes sense. I agree with pre-approved questions getting their own page, and having this as page 5 works for me.

So with these suggestions, it would look like this:

Page 1: "De studie"

Sub-page 1 (not-in-procreg) 'Onderzoeker'

Sub-page 2 "Mede onderzoekers"

Sub-page 3 "Funding"

Page 2: "Onderzoeksdoel"

Page 3: "Pre-approved questions" (optional)

This still leaves certain subpages quite long ... But I do find it quite coherent like this.

djhcapel commented 1 month ago

This sounds like a logical solution, but I still have some remarks/questions:

EdoStorm96 commented 1 month ago

So I've discussed this with the secretary, and I've incorporated her ideas into the order I have outlined above. So I will start implementing this.