DH-IT-Portal-Development / ethics

Ethical Committee web application in Django
http://fetc.hum.uu.nl
MIT License
2 stars 1 forks source link

Initial DSC & Django update #660

Closed tymees closed 6 months ago

tymees commented 7 months ago

This PR lays the foundations to built V4 upon.

Note: this PR targets the major/4 branch for now. This is a fork of develop made at the same time as the source branch, to have a clear diff. New changes in develop will need to be merged into there as well.

It's a rather large PR; I've tried to make proper commits for individual changes, to help reviewing. I've also added some comments over adding them here, such that the comment is located near the relevant code. Also, please ignore the changes in the docs folder. Those are caused by my bulk-refactors.

Highlights:

Still todo: Well, a lot. A non-exhaustive list:

tymees commented 7 months ago

Thanks for the review!

I've added a commit that refactors all uses of uil_filters.

There are probably more of these 'well you could've done that in bulk' problems still living in other places; I've only done those I was aware of, and those I found during my work on the pages I gave individual attention.

Normally we go with the 'one approval is enough' strategy, but I really want @miggol's review before merging, as it's quite an impactfull PR.