Note: once again this PR targets acceptation, as I deem this fix important enough to deploy quickly. It can be cleanly applied to develop too tho, if that's what ya'll prefer
I've tested if the problem is related to the first login, and while I was skeptical it really was this problem, it does seem to be. So, this PR adds one line of code to ensure the user model is saved first. As this 'field' is the last to be 'set', it should be save to do. (And even if that's not the case, our try/catch will prevent any real problems for the user).
I'm still a bit mystified why the percentage of users without a faculty set is this high if it's only a problem for initial logins... But this fix should at least aleviate the problem a bit.
Re #611
Note: once again this PR targets acceptation, as I deem this fix important enough to deploy quickly. It can be cleanly applied to develop too tho, if that's what ya'll prefer
I've tested if the problem is related to the first login, and while I was skeptical it really was this problem, it does seem to be. So, this PR adds one line of code to ensure the user model is saved first. As this 'field' is the last to be 'set', it should be save to do. (And even if that's not the case, our try/catch will prevent any real problems for the user).
I'm still a bit mystified why the percentage of users without a faculty set is this high if it's only a problem for initial logins... But this fix should at least aleviate the problem a bit.