DH-IT-Portal-Development / ethics

Ethical Committee web application in Django
http://fetc.hum.uu.nl
MIT License
2 stars 1 forks source link

Niet verder in behandeling genomen - dates are swopped #677

Open djhcapel opened 5 months ago

djhcapel commented 5 months ago

In cases where the assessment procedure is stopped without a formal decision (e.g. withdrawal of application), something goes wrong with the dates:

The date "Laatste beoordeling ontvangen op" seems to be swopped with the date "Afhandeling: Niet verder in behandeling genomen". This also leads to errors in the statistics.

tymees commented 5 months ago

For something to be swapped, there actually needs two things that swap places. That is not the case here, there is only one date with a misleading label. A correcter name would be 'Date review ended'; This normally corresponds to 'date last decision', but in this case the review wasn't ended because the last decision was received.

(Internally, the field is actually called date_ended).

That being said, that's just a explanation for this behavior. It also points us to a potential fix: a new field date_last_decision. This field should be updated every time a decision is made (hint: Decision.update_go); That way, the field will correspond to date_end when the review is closed normally, but will have a sensical name in the discontinue scenario.

djhcapel commented 5 months ago

Not sure if I understand this correctly. There can be two dates in case of 'niet verder in behandeling genomen', but this does not necessarily have to be the case. In principle, an application can be 'niet verder in behandeling genomen' at any time, also right after submission. In some cases, a first decision has already been sent, and that date should be the date the applicant was informed about that decision. The date 'niet verder in behandeling genomen' can be an entirely different date.