DH-IT-Portal-Development / ethics

Ethical Committee web application in Django
http://fetc.hum.uu.nl
MIT License
2 stars 1 forks source link

Fix/small django4 fixes #685

Closed miggol closed 3 months ago

miggol commented 3 months ago

This fixes two issues:

  1. A selfexplanatory issue with reverse URLs in validate_proposal.py
  2. Study names aren't inserted into StudyStartForm's data, causing a KeyError

With regards to the second issue, I admit that I haven't looked deep into the mechanics causing this. I'm a bit apprehensive for messing with the behaviour of SoftValidationMixin, which is a bit of a beast that we rely on in many places. This is just what I cooked up quickly so that I could test the rest of #684, and I'm open to better solutions.