search

DH-IT-Portal-Development / ethics

Ethical Committee web application in Django
http://fetc.hum.uu.nl
MIT License
2 stars 1 forks source link

Fix/improve forms UI #687

Closed EdoStorm96 closed 2 months ago

EdoStorm96 commented 3 months ago

Here is a mishmash of different small issues. Mostly to do with improving error displays, and general UI improvements for the forms, mostly around sessions and tasks ...

I also found out the non-field-errors were not caught by validation, so I added a small fix for this.

EdoStorm96 commented 2 months ago

Ok, So I've adressed your comments, and I also found some bugs, which I fixed along the way.

I noticed that StudyEndForm was missing from the validation, so I've added that. (I see now that I put the wrong commit message regarding this ... oh well.) -> 9899ca7

I found a bug in this form. It was, unnecessarily receiving a study kwarg, this is now fixed.

And I tried to work on StudyDesignForm, and made some changes that will hopefully make this form easier to validate externally. However, as I showed, I did run into a really strang bug, where this form does not get properly initialized in the validator. Its clean method does not get called, and I cannot figure out why this is. I would really appreciate if you could have a look at this, because it is driving me crazy!