DH-IT-Portal-Development / ethics

Ethical Committee web application in Django
http://fetc.hum.uu.nl
MIT License
2 stars 1 forks source link

Feature/revise study end questions 4 #707

Closed EdoStorm96 closed 1 month ago

EdoStorm96 commented 1 month ago

fixes #546. This was an olde branch I had worked on. This implementation is not entirely what we settled on, as we initially wanted to also have a small table representing the trajectories on the Knowledge Security page if there were multiple trajectories. I do still have a template lying around for this somewhere ... But I don't think it is the most important thing now. At least we have the updated questions/texts in here now.

As far as I can tell, everything here is working well. Though there are a lot of changes, nothing too crazy happening.

EdoStorm96 commented 1 month ago

So, I've addressed your comments. The translations were a lot of work, because a lot of stuff was behind (#705 ...). I promise to keep translations up-to-date from now on 😔.

Most of the translations regarding this branch I've pulled from my old branch. Other things, which I've previously forgotten, I've just translated to my best intuition ... This should bring most of the translations for major/4 up to date.

EdoStorm96 commented 1 month ago

Ok, I've also adressed a dead link on index.html here. I ran into this during the translations. fixes #710.

EdoStorm96 commented 1 month ago

Woops, so I missed the issue with the tests you pointed out, which turned me onto the other issue with the tests, that we discussed earlier.