DIYgod / RSSHub

🧡 Everything is RSSible
https://docs.rsshub.app
MIT License
32.59k stars 7.27k forks source link

VICE route, unsupported role #15736

Closed K33k0 closed 4 months ago

K33k0 commented 4 months ago

Routes

/topic/:topic/:language?

Full routes

/vice/topic/cleveland/en
/vice/topic/assault/en
/vice/topic/hacking/en

Related documentation

https://docs.rsshub.app/routes/traditional-media#vice

What is expected?

I believe the feed should still render even if an unhandled component is found.

What is actually happening?

Deployment information

Self-hosted

Deployment information (for self-hosted)

OS: Linux, Node: 22.1.0

Additional info

Further investigation has shown there are many different roles within the NEXT_DATA on the article pages. Unfortunately I can t see a published list of all NEXT_DATA components, meaning that a new role could pop up at any time. 

All these extra components are essentially internal ads pointing to other articles. 

I will create a new pull request, that instead of throwing an error, it will skip rendering the invalid components. This way the feeds work and the articles remain clean and ad free.

This is not a duplicated issue

github-actions[bot] commented 4 months ago
Searching for maintainers:

To maintainers: if you are not willing to be disturbed, list your username in scripts/workflow/test-issue/call-maintainer.js. In this way, your username will be wrapped in an inline code block when tagged so you will not be notified.

If all routes can not be found, the issue will be closed automatically. Please use NOROUTE for a route-irrelevant issue or leave a comment if it is a mistake. 如果所有路由都无法匹配,issue 将会被自动关闭。如果 issue 和路由无关,请使用 NOROUTE 关键词,或者留下评论。我们会重新审核。