search

DLu / roscompile

106 stars 19 forks source link

roscompile suggests removing exec_depend from package.xml in meta package #73

Closed 130s closed 3 years ago

130s commented 4 years ago

Problem

I don't have publicly-shareable example yet (if desired I might be able to provide shareable sample) but I'm seeing:

        Removing exec_depend nora_rs
        Removing exec_depend nora_utils
        Removing exec_depend rt
        Removing exec_depend rppb
+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+| update_metapackage (nora_sdk)                                                                                                                                                                                                                                                   |+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
--- package.xml
+++ package.xml (modified)
@@ -9,10 +9,6 @@
   <buildtool_depend>catkin</buildtool_depend>
-  <exec_depend>nora_rs</exec_depend>
-  <exec_depend>nora_utils</exec_depend>
-  <exec_depend>rt</exec_depend>
-  <exec_depend>rppb</exec_depend>
   <export>
     <metapackage/>
   </export>

Would you like to make this change? [y/N]

Isn't exec_depend valid thing to do for a meta pkg? REP-140

DLu commented 4 years ago

Whoops. Thanks for reporting this.

This is actually only a bug with the interactive version of that rule, but it still needs to be fixed.