search

DMTF / RDE-Dictionary

Dictionary generator for Redfish Device Enablement
Other
4 stars 5 forks source link

generate_dictionaries.py pointed to v1_0_0 of annotations schema #57

Closed kilgorep closed 1 year ago

kilgorep commented 1 year ago

The step in generate_dicionaries.py to build the binary and map files for the annotations schema dictionary was pointing to a hard-coded schema version of v1_0_0, preventing any new annotations added later on from being included in the dictionary binary. This script now will attempt to build the dictionary binary using redfish-payload-annotations-v1.json, which is a clone of the latest version of the annotation schema.

Also fixed a bug when building a list of annotation schema JSON files with version less than a given version string could result in inconsistent ordering of list members, potentially resulting in nondeterministic sequence numbers being assigned to annotations.

Also fixed a bug where the version32 form of schema version strings was erroneously being used to compare versions. This would result in cases such as 'v1_2_0` (0xF1F2F000) being determined to be newer than 'v1_12_0' (0xF112F000).

mraineri commented 1 year ago

We should also look at some of the Travis errors and automated version bumps for packages. We can do that later and not hold up this PR.