DPIclimate / broker

3 stars 3 forks source link

EagleIO poller creating dup messages #68

Open dajtxx opened 5 months ago

dajtxx commented 5 months ago

The EagleIO poller is using a message hash to try and avoid dup messages but it doesn't seem to be working.

See logical device 283 for example. Some data points are being recorded many times, with a timestamp from 2022.

Perhaps the hash calculation is using too much info so something is changing the hash when the data points themselves are not changing.

I now see some of the values are changing, eg salinity & temperature are not getting value-specific timestamps, but these ones that are not changing such as battV, adc ch3, etc keep getting added to the message even though their timestamps and values are not changing.

That explains why the hash keeps changing, and it would do so even if only calculated using the timeseries array.

We should talk about this and see whether those old values can or should be filtered out.

bsefton12 commented 5 months ago

It's possible this was due to Fisheries recently removing a C4E due to failure. The node was still transmitting battery etc so the poller was updating and transmitting the old salinity/temperature values. Not 100% sure this is the issue so I'll leave this open for now.