search

DRIVER-EU / sumo-connector

Connecting the Test-bed to DLR's open-source traffic simulator SUMO.
MIT License
1 stars 2 forks source link

Unit transport request: notification of arrival #10

Open erikvullings opened 5 years ago

erikvullings commented 5 years ago

Upon arriving at the destination, can you share this information? I see three options, but am not sure which one is best:

  1. simulation_entity_item: set moveable to false. However, this may be interpreted as an entity that can never move.
  2. simulation_entity_item: set a user tag, e.g. "arrived: true". Rather sensitive to changes.
  3. simulation_entity_item: add a new property, status, e.g. with an enumeration of arrived, travelling, parked, waiting_for_traffic_sign, waiting_for_obstacle, etc.
  4. new message: simulation_entity_item_arrived, containing the entity's ID.

I have a preference for the last one: although it requires a new message (and topic), its intention is very clear and precise. And from a TMT point of view, it is easy, since I would only need to monitor this topic. On the other hand, #3 is elegant too, and it provides others more insight into what the vehicle is doing.

e-tinus commented 5 years ago

For me, option 3 isn't a bad one, but then we need to make sure the "status" property is only used for movement (even renaming it to movementStatus). This would then also deprecate the "moveable" property, since it can also be a movement status. I would however, if choosing for option 3, make the values very generic, so it can be used by any simulator dealing with movement.

Option 4 is also very viable, especially when the movement is becoming very specific for a particular simulator.

behrisch commented 5 years ago

I don't think I can fill the status field of option 3 easily with meaningful values. Of course I can say whether the vehicle is stopped but I would simply evaluate the speed being 0, which is already part of the message. Whether the vehicle is waiting for a traffic light or for another vehicle, for instance, is subject to interpretation if it is the last one in a long queue. Parking is not modelled in driver (yet?), so this is no meaningful value as well, unless we want to change that. So I would rather go for option 4.

behrisch commented 5 years ago

@erikvullings Opinions? Should we go for option 4?