search

DSE-MSU / DeepRobust

A pytorch adversarial library for attack and defense methods on images and graphs
MIT License
995 stars 192 forks source link

Issue With Dataset library in deeprobust for Setting as prognn and for Windows Platform. #136

Open ratnadeepdas97 opened 1 year ago

ratnadeepdas97 commented 1 year ago

Hi Team,

I found an issue in the dataset.py file found in the path deeprobust-0.2.8\deeprobust\graph\data which is used when we call Dataset class like from deeprobust.graph.data import Dataset

This class does not run, when the setting is done as 'prognn' and run on Windows. It throws and error saying that the Dataset has no attribute 'root'.

Error Screenshot -

Error message This bug is because of the following code in line 67 as below

if platform.system() == 'Windows': root = root else: self.root = osp.expanduser(osp.normpath(root))

Code Screenshot -

Code

Instead this bug is fixed after a minor modification in the code as

if platform.system() == 'Windows': self.root = root else: self.root = osp.expanduser(osp.normpath(root))

I would like to request to take notice of it.

Thanks, Ratnadeep

ratnadeepdas97 commented 1 year ago

@ChandlerBang I raised this issue over a month ago. But no response on it yet?

ChandlerBang commented 1 year ago

Sorry that I was busy with job search. Thank you for the comments and I just resolved this issue.