search

DSE-MSU / DeepRobust

A pytorch adversarial library for attack and defense methods on images and graphs
MIT License
994 stars 192 forks source link

scikit_learn --> scikit-learn ? #61

Closed achangeo closed 3 years ago

achangeo commented 3 years ago

Thinking this may be an error. Not finding it on pypi but found https://pypi.org/project/scikit-learn/

https://github.com/DSE-MSU/DeepRobust/blob/6a392188fb586155161db707756f4255760d6f5c/requirements.txt#L11

https://github.com/DSE-MSU/DeepRobust/blob/master/setup.py#L28

ChandlerBang commented 3 years ago

hmmm, I just tried pip install scikit_learn==0.22.1 and it works fine for me...

ChandlerBang commented 3 years ago

Will it throw an error if you run the command above?

achangeo commented 3 years ago

Not an actual error I misspoke. Saw it referred to in official documentation more as the hyphenated name and wanted to point it out is all!

ChandlerBang commented 3 years ago

Ok, I've updated it. Thanks!