search

DUNE-DAQ / fdreadoutlibs

fdreadoutlibs
0 stars 3 forks source link

aabedabu/adc peak feature #149

Closed hristovaivana closed 7 months ago

hristovaivana commented 9 months ago

We would like to merge this branch to develop. This branch provides enhancement of the hit peak time and the hit peak ADC value as requested in https://github.com/DUNE-DAQ/fdreadoutlibs/issues/89

The branch has been tested and validated, but one last final test with an APA and fake data would be good to confirm that the branch runs with the latest DUNEDAQ setup.

adam-abed-abud commented 9 months ago

Hi Ivana, thanks for the PR. I see that there are a lot of variables in the code related to the previous testing of yours like m_hits_dest32u and m_hits_dest16i . If they are not needed please remove them.

hristovaivana commented 9 months ago

Hi Adam, thank you very much for the useful comments. I've pushed the fixes that address the remarks above.

adam-abed-abud commented 9 months ago

Waiting for the last tests on NP04 before merging the changes.

hristovaivana commented 8 months ago

Hi Adam, thanks for requesting synthetic and real data tests for this PR. I confirm that the synthetic test passed with the additional change of the time over threshold calculation, which has been pushed to the branch for review. I ran the following test pytest -s sourcecode/daqsystemtest/integtest/tpstream_writing_test.py The next step is to run a test at EHN1/NP04.