search

DUNE-DAQ / fdreadoutlibs

fdreadoutlibs
0 stars 3 forks source link

TPSet SkipList Scope Guards #200

Closed aeoranday closed 1 month ago

aeoranday commented 1 month ago

I've added scope guards around the skip list accessing in a similar fashion to the DefaultSkipListRequestHandler.

At the same time, while trying to understand where these guards should actually go, I rearranged and reformatted to try to improve readability. A significant portion of this involved whitespace changes according to our style guide, so it is likely easier to review with the ignore whitespace option.

This was tested on NP04 and achieved (at least) consistent performance.

alessandrothea commented 1 month ago

to be specific, it looks good from a logical standpoint, but I don't that the changes has any impact on performance, since the scope of the guard hasn't really changed.