DUNE-DAQ / fdreadoutlibs

fdreadoutlibs
0 stars 3 forks source link

Patch on dunedaq v3.0.1 and v3.1.0 - Fix memory leak #32

Closed hristovaivana closed 2 years ago

hristovaivana commented 2 years ago

The changes in this branch are intended for the ongoing HD tests using WIB2. These are the minimal changes for extended firmware tests with new builds and WIB2. This branch can also be merged to develop and included in dunedaq v3.1.0. The changes are:

  1. Adapt raw WIB TP frame header to the WIB2 format. This file is supposed to be moved to detdataformats repository at https://github.com/DUNE-DAQ/detdataformats/blob/develop/include/detdataformats/wib/RawWIBTp.hpp and removed from https://github.com/DUNE-DAQ/fdreadoutlibs/blob/hristova/patch_on_3.0.1/wib2/include/fdreadoutlibs/wib/RawWIBTp.hpp I don't have permission to push a branch to detdataformats.

  2. Fix memory leak in RAWWIBTriggerPrimitiveProcessor which was discovered during the VD coldbox test in June 2022 https://github.com/DUNE-DAQ/fdreadoutlibs/issues/24 The memory leak fix is critical for taking long runs overnight and testing long term system stability.

hristovaivana commented 2 years ago

This PR will be closed and superceded by the next. https://github.com/DUNE-DAQ/fdreadoutlibs/pull/33