search

DUNE-DAQ / fdreadoutlibs

fdreadoutlibs
0 stars 3 forks source link

Hristova/fwtp stitch config #35

Closed hristovaivana closed 2 years ago

hristovaivana commented 2 years ago

This PR addresses https://github.com/DUNE-DAQ/fdreadoutlibs/issues/24 https://github.com/DUNE-DAQ/fdreadoutlibs/issues/27 The firmware TP stitching uses the number of ticks between the packed WIB frames (64 frames in a packet). This number was 1600 for WIB1 and 2000 for WIB2. This is now made a configurable parameter. Each so called WIB-to-TP packet consists of 64 WIB frames, with consecutive timestamps, packed in a format suitable for the firmware TPG. This change is requires PR https://github.com/DUNE-DAQ/readoutlibs/pull/46

This branch uses the new WIB2-related header change in the firmware TP frame format: https://github.com/DUNE-DAQ/detdataformats/tree/jbrooke/fw_tp_update

FD readout types are synchronised with the changes in detdataformats, where we now use the name RawTp from the namespace fwtp. This change requires PR https://github.com/DUNE-DAQ/detdataformats/pull/32

This PR supercedes the previous https://github.com/DUNE-DAQ/fdreadoutlibs/pull/34 https://github.com/DUNE-DAQ/fdreadoutlibs/pull/33 https://github.com/DUNE-DAQ/fdreadoutlibs/pull/32

hristovaivana commented 2 years ago

@jimbrooke I closed the previous PRs and this PR is ready for your review.

jimbrooke commented 2 years ago

Corresponding changes are already in detdataformats, so merging this now.