search

DUNE-DAQ / fdreadoutlibs

fdreadoutlibs
0 stars 3 forks source link

Could locally defined timestamp_t in readout code be replaced with daqdataformats::timestamp_t? #83

Open bieryAtFnal opened 1 year ago

bieryAtFnal commented 1 year ago

I noticed that several of our FrameProcessor, etc. files use a locally declared "using" statement to define a local timestamp_t data type rather than using daqdataformats::timestamp_t.

Could this be changed so that we don't have multiple definitions of timestamp_t?

./ssp/SSPFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wibeth/WIBEthFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./daphne/DAPHNEStreamFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./daphne/DAPHNEFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib/SWWIBTriggerPrimitiveProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib/WIBFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/WIB2FrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/SWWIBTriggerPrimitiveProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/RAWWIBTriggerPrimitiveProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./tde/TDEFrameProcessor.hpp:  using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)