search

DUWS-R-Team / DUWS-R

ArmA 3 Dynamic Universal War System - Rebirth
42 stars 18 forks source link

Dedicated Support rebuild and refactor #145

Open ultranoobian opened 7 years ago

ultranoobian commented 7 years ago

Expected: A working, breathing, and manageable dedicated setup.

amanuense commented 6 years ago

might want to take a look to my fork, the changes to make it work on dedi aren't that big.

CurePindal commented 6 years ago

might want to take a look to my fork, the changes to make it work on dedi aren't that big.

And why dont you supply those fixes via Pull Request?

amanuense commented 6 years ago

because I made several other changes, merging the two forks will take a while and honestly I don't have the time for that. the other changes are small but they are too many, I refactored a lot of the code, to my bad luck I am a Software developer for a big company and applied a lot of the things I thought would improve maintainability the problem is that merging will be complicated.

Oscar

On 28 February 2018 at 04:58, CurePindal notifications@github.com wrote:

might want to take a look to my fork, the changes to make it work on dedi aren't that big. And why dont you supply those fixes via Pull Request?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DUWS-R-Team/DUWS-R/issues/145#issuecomment-369231533, or mute the thread https://github.com/notifications/unsubscribe-auth/AL6AvRmJZumSMpXNah1VDofW62cCvTs4ks5tZU2FgaJpZM4M0Jvo .

amanuense commented 6 years ago

forgot to mention, I provided a similar yet more complete answer of why I haven't created a pull request, but if you want to create one, I'll be happy to guide you though the changes I made so you can do effective merging. HC support is completely missing but most of the other changes I made should be "fairly" simple to pull if you have the time.