search

DUWS-R-Team / DUWS-R

ArmA 3 Dynamic Universal War System - Rebirth
42 stars 18 forks source link

Manually place enemy zones #26

Closed bolbies closed 9 years ago

bolbies commented 9 years ago

Issue

Fixes #33

Summary

First commit. I hope I'm doing this right!

fritogotlayed commented 9 years ago

@bolbies You're doing just fine. What issue number where you trying to resolve with this or was there another issue? If it was another issue I can create an issue and we can go from there. From this side it looks like you created the PR just fine :+1:

fritogotlayed commented 9 years ago

:eyes: Looking at this now.

fritogotlayed commented 9 years ago

@bolbies Done with my first pass review. I have to head out right now... dang wife... Also, thanks a ton for the contribution! The purpose of the code review is not to attack you or your code but rather to make a higher quality mission for everyone :-).

@naitp @phr0gz Feel free to review as well. I only spent about 10 minutes on the first pass. I'll review again later when I get back home.

Verdict - :no_good:

bolbies commented 9 years ago

I think I fixed the tabs. I'll make sure of that next time I post something. And the issue was from my own commit, not any of yours.

fritogotlayed commented 9 years ago

@bolbies I checked out your manual-zones branch and built the pbo to play local. When the game launched I manually placed my HQ. When I got to the zone screen I clicked the "START-M" button but nothing happens. Am I missing something here?

bolbies commented 9 years ago

I used the find/replace word tool to quickly turn the tabs into spaces and one of the variables at the bottom of startup_start2 got messed up. Sorry. Try it now.

fritogotlayed commented 9 years ago

@bolbies Ha. Not a problem. Have you tried an IDE like IntelliJ or SQF Editor? Both have an option to convert whitespace to spaces. It'll safely change tabs to spaces. I use both interchangeably.

bolbies commented 9 years ago

Guess who's never using the replace tool ever again? Fixes are up. Hopefully it works now!

fritogotlayed commented 9 years ago

Haha, it happens to all of us. I've been on the phone most of the evening and probably wont get to this until Wednesday. Thanks for making the edits! I strongly suggest using something like Squint, SQF Editor or IntelliJ with the SQF Plugin. All of the have an option to automatically convert tabs (\t) to spaces.

bolbies commented 9 years ago

Yeah I downloaded Squint so I'll see how that works out later when I start something else. I'll see if I can knock out a few of the posted issues next. This is fun :)

fritogotlayed commented 9 years ago

@bolbies All looked good to me from a code standpoint. Thanks for the addition. One area for improvement I'd like to see is that sometimes when I click nothing registers so I don't know if the script is analyzing to make sure the location I clicked is valid or if it's an invalid location. I'll create a new issue for this and we can address it in another PR.

Also, I'm going to make some edits to get your PR into the format I'm planning to use going forward. This isn't a code edit; It's strictly just on this PR.

fritogotlayed commented 9 years ago

@bolbies You should join the @DUWS-R-Team/developers team. We would love to have you!