search

DUWS-R-Team / DUWS-R

ArmA 3 Dynamic Universal War System - Rebirth
42 stars 18 forks source link

update vehicle lists #70

Closed rlex closed 9 years ago

rlex commented 9 years ago

Issues

Fixes #73

Summary

Add more vehicles into vehicle requests menu, including Heli DLC ones.

fritogotlayed commented 9 years ago

@rlex I was going to merge this one today as well but the patch with the updated formatting needs to be applied. :smile:

rlex commented 9 years ago

Doesn't have a lot of time to rebase it, but i'll do this. Question here: We can add vehicles from most used mods (RHS). I wrote simple check for if exists CfgVehicle, so it blocks request and warns player if mod is not installed. Already included in my DUWS Modified fork, waiting for feedback... So, should i include them as well?

fritogotlayed commented 9 years ago

If I understand correctly the warning blocks the thread until the user provides feedback. I assume that's clicking an "OK" button or something. If that is true I'd say don't add that in. It would give users without the mods a worse experience than they have now.

If that's not the case feel free to add it to the PR and I'll review it once again.

rlex commented 9 years ago

No, warning shows "mod X is not installed" and blocks CP deduction from CP pool. It does not affect gameplay at all, and RHS seems to be most popular addon for A3.

Here: https://github.com/rlex/a3-duws-unofficial in vehicle_request.sqf

fritogotlayed commented 9 years ago

Okay. I think I understand now. I think it's a bad experience to show the player an option in a menu that they cannot use because they do not have a mod installed. I can see two options here...

1.) Don't add the RHS stuff to this PR and add it in a future PR. (Also, just apply that patch linked above so the formatting is "nice" 2.) Add the RHS vehicle code but include the check using CfgVehicle in both places; The spot where the vehicles are added to the purchase list and the spot in the purchase logic that blocks the purchase.

rlex commented 9 years ago

I thought about hiding units from request menu, but this will completely break request array. So i think i'll maintain my "modded" version and just PR clean list without modded vehicles.

fritogotlayed commented 9 years ago

Closing this PR as I have created a new one with the requested patch above already applied. The new PR is located at https://github.com/DUWS-R-Team/DUWS-R/pull/102