0.1.7 breaks build w/ uglifyjs

cwalv commented 7 years ago

including this in a create-react-app project, with 0.1.6 everything built fine, but with 0.1.7 I get:

$ npm run build

> haas-react-ui@0.1.0 build S:\source\git\tmp
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

static/js/main.8d3da965.js from UglifyJs
SyntaxError: Unexpected token: name (events) [./~/signalr-no-jquery/build/jQueryShim.js:7,0]

zdh8675 commented 7 years ago

I have solved the problem, but my code environment is vue.js

You can look at this link, may be helpful： http://www.ruanyifeng.com/blog/2016/01/babel.html

Alternatively, Babel provides a REPL online compiler that can convert ES6 code to ES5 code online. The converted code can be run directly as an ES5 code into a web page. Open the following link: https://babeljs.io/repl/#?babili=false&evaluate=true&lineWrap=false&presets=es2015%2Creact%2Cstage-2&targets=&browsers=&builtIns=false&debug=false&code=

gtwilliams03 commented 7 years ago

It is the "let" statements in the updated jQueryShim.js file. But I don't see a problem with the babel settings. Yet. But I'm getting the same error and I didn't with my fork.

gtwilliams03 commented 7 years ago

Removed signalr-no-jquery. Removed babel-loader and upgraded to babel-loader v7. Reinstalled signalr-no-jquery and it passes with no UglifyJs errors. Not sure if this is the exact sequence because I was trying a bunch of things, but it is working now.