search

DVLP / signalr-no-jquery

120 stars 77 forks source link

Fixes issue #1 Switched from connection.url to connection.appRelative… #2

Closed viktorlarsson closed 7 years ago

viktorlarsson commented 7 years ago

…Url inside transportlogic.getUrl

AnasTawfeek commented 7 years ago

I just had the same issue but was going to replace it with a more complex solution: url = transport === "webSockets" ? "/signalr" : connection.url, then i found your clean solution in the pull-request but stuck in the conflict, will you fix this? or I start a new pull-request?

viktorlarsson commented 7 years ago

I tried to merge this fork, but it seems like the author does not feel comfortable merging it. You can follow the discussion here: https://github.com/DVLP/signalr-no-jquery/issues/1

We are actually using my fork in production right now, due to this reason.

"dependencies": { "signalr-no-jquery": "https://github.com/viktorlarsson/signalr-no-jquery.git" },

DVLP commented 7 years ago

Thanks for contributing. This was remaining unfixed because my client's application was only working with this bug. Now I applied this change manually because of conflicts since then