search

DWilliames / paddy2-beta

Beta for the next version of the Paddy Sketch Plugin
MIT License
146 stars 5 forks source link

[Bug] When padding is applied, keep all elements on whole pixels and resize them to whole pixels #7

Open tschmeisser opened 6 years ago

tschmeisser commented 6 years ago

To Recreate

Apply padding to a background that contains other shapes and then resize the whole group.

What Happens

Elements that fall on decimal pixels and that have decimal sizing appear blurry in Sketch and exported assets.

What's Expected

Elements would remain unblurry and lie on whole pixels.

Thanks!

paddy-demo-180508

Working file: https://www.dropbox.com/s/qio8m4wvhpypntr/Paddy-Demo-180508.sketch?dl=0

DWilliames commented 6 years ago

Thank @trvsss 👍

Yeah, it should snap to whole pixels if you have 'Pixel fitting' turned on.

Do you have it turned on in your Sketch preferences? screen shot 2018-05-09 at 9 46 31 pm

Or do you think it should always snap to whole decimals regardless of if you have 'pixel fitting' turned on?

tschmeisser commented 6 years ago

I do have that feature on. Maybe it should respect that setting? I can't think of reasons to use Paddy and want things off pixel though given it's mostly centered around UI design.

On Wed, May 9, 2018 at 7:48 AM David Williames notifications@github.com wrote:

Thank @trvsss https://github.com/trvsss 👍

Yeah, it should snap to whole pixels if you have 'Pixel fitting' turned on.

Do you have it turned on in your Sketch preferences? [image: screen shot 2018-05-09 at 9 46 31 pm] https://user-images.githubusercontent.com/6570446/39813143-a1b87782-53d2-11e8-8a28-62cd2f5c27d8.png

Or do you think it should always snap to whole decimals regardless of if you have 'pixel fitting' turned on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DWilliames/paddy2-beta/issues/7#issuecomment-387713096, or mute the thread https://github.com/notifications/unsubscribe-auth/AArzZLIiGOoKOYkV2k2KFcGEDEBPe7i3ks5twtecgaJpZM4T250x .

tschmeisser commented 6 years ago

By the way, just wanted ot say nice work @DWilliames , this new release already feels way more solid than the first version even in it's beta state.

DWilliames commented 6 years ago

Thanks @trvsss really appreciate it. I'll look into this more. That's a good point. Maybe it should always be set to whole decimals.