search

DanDiplo / Umbraco.AuditLogViewer

An audit and content log table viewer for Umbraco CMS
https://www.diplo.co.uk/blog/web-development/diplo-audit-log-viewer-for-umbraco-10/
16 stars 7 forks source link

replace 'search to type' with search button #7

Closed shemsiu closed 4 years ago

shemsiu commented 4 years ago

Hi Dan Diplo,

During development we faced a lot of issue with "Search to type" functionality. There wasn't any debounce or a minimum searchterm length which causes a lot of network requests to happen. Those many request resulted in Sql Timeout Exceptions.

Instead of "Search to type", we recommend to enable "enter" and use an Umbraco button (stateful). While the request is pending the form will not allow for further requests.

Best regards, Vigan

DanDiplo commented 4 years ago

Makes sense, though I've never personally hit any timeout issues. Maybe your database is much larger than on the sites I tested it on? I'll have a look at adding it into next release... Cheers!

DanDiplo commented 4 years ago

Lucky had a little spare time at lunch, so built a new NuGet package and uploaded it:

https://www.nuget.org/packages/Diplo.AuditLogViewer/1.1.1

Let me know if that works for you?

shemsiu commented 4 years ago

Thanks, it works as supposed :)