Improve ASI algorithm - Githubissues

DanielXMoore / Civet

A TypeScript superset that favors more types and less typing

https://civet.dev

MIT License

1.33k stars 28 forks source link

Improve ASI algorithm #1170

Closed edemaine closed 2 months ago

edemaine commented 2 months ago

Run ASI algorithm in class bodies; previously they were type: "ClassBody" so completely ignored. Now they're type: "BlockStatement" with subtype: "ClassBody" (in case we need to know someday).
Recurse into first non-null child/array element instead of just first, and add a string base case. This seems like a better-behaved recursion. Probably some cases of the switch could now be eliminated, but I didn't try.

Fixes #1169

edemaine commented 2 months ago

It is a special kind of block, with e.g. assignments. I actually don't know what happens if you pit function calls in there. Certainly methods are special. If it ends up being a problem, we can certainly complicate the ASI code to consider multiple block-like things. But e.g. the new ampersand code in working on probably also wants class bodies to be considered blocks.