DanielXMoore / Civet

A TypeScript superset that favors more types and less typing
https://civet.dev
MIT License
1.33k stars 28 forks source link

Upgrade TypeScript #1294

Closed edemaine closed 5 days ago

edemaine commented 5 days ago

TypeScript 5.5 should save us from having to give explicit types for type predicates, so it's a worthy improvement to the LSP in particular.

I did a simple test (counting errors from civet --typecheck source/**/*.civet) and it went down from 863 to 836. Not a huge decrease but a good sign!

Side note: A bunch of these ~800 errors aren't "real" (don't show up in the LSP); it seems that civet --typecheck isn't getting the type declarations from Node, so probably failing to load tsconfig.json somehow. Once resolved, we might make this a CI process to help count the number of errors and watch it go down, as in the mission of #1283.