Open zoodogood opened 2 weeks ago
Could you rebase against our main branch? There seems to be a lot of other commits here.
Oops. I'm redoing the pull request now. Or does it merge into pure history?
Yeah, I noticed that, too. It's gonna take me a little while
If you setup a remote of upstream
to refer to our repo/fork (git remote add upstream git@github.com:DanielXMoore/Civet.git
), then git rebase -i upstream/main
, then git push -f
(after checking everything is still OK), the PR will update.
If you setup a remote of
upstream
to refer to our repo/fork (git remote add upstream git@github.com:DanielXMoore/Civet.git
), thengit rebase -i upstream/main
, thengit push -f
(after checking everything is still OK), the PR will update.
Thank you, that helped.
@edemaine I think it's ready. Can you check?
Thank you for taking the time to check the code and suggesting ways to improve it
The import path now has the same highlighting as the string literal (string.unquoted.module-reference.civet). Previously it could be colored with anything
Before pull
export a, b from x
toofrom x import {a, b}
I have been unable to determine the correct method for intercepting the block completion
so this part is not part of the import expression, which is semantically wrong. Any criticism is welcome, I'm inexperienced