LSP Bugs: tokenizing / highlighting list

DanielXMoore / Civet

A TypeScript superset that favors more types and less typing

https://civet.dev

MIT License

1.55k stars 33 forks source link

LSP Bugs: tokenizing / highlighting list #266

Open tomByrer opened 1 year ago

tomByrer commented 1 year ago

https://v8.dev/features/numeric-separators

Toenizes incorrectly in VSCode & playground, but still works when translated to JS in Playground:

test .= 9_999_999_999_999 + 1
console.log `value = ${test}

tomByrer commented 1 year ago

There are many differences in tokens, listed on Discord. Not sure if you want separate issue each?

edemaine commented 1 year ago

Maybe a checklist in this one issue would be most helpful?

tomByrer commented 1 year ago

item : JS , Civet

[ ] const : storage.type , keyword
[ ] require : entity.name . function,
[ ] console : variable , entity.name.type (Civet might be better here)
[ ] 9_999_999_999_999 : constant.numeric , invalid (BUG)
[ ] ${} inside ${} : punctuation.definition.template-expression.begin.js (etc) , punctuation.section.embedded.civet
[ ] () inside arrow func : punctuation.definition.block.js , meta.brace.curly.civet
[ ] Date() : entity.name.function , entity.name.type
[ ] info in info.videoDetails : variable.other.object.js , variable, No theme selector

tomByrer commented 1 year ago

BTBH, it would be better if you search for the highlight issues, since there is so many & I don't know what is intentional or not. Keep in mind many of we who want to use Civet will likely be coming from JS/TS, so we expect more or less the same syntax highlights, though exceptions for the new syntax would be OK, if not expected to welcome.

Press F1, search for tokens, then you can click around

cheers