Resolving #19, can reference hostIP to construct endpoint

DataDog / kong-plugin-ddtrace

Datadog APM Plugin for Kong Gateway

Apache License 2.0

15 stars 7 forks source link

Resolving #19, can reference hostIP to construct endpoint #20

Closed xpdable closed 6 months ago

xpdable commented 7 months ago

Resolving #19, can reference hostIP to construct endpoint inside the plugin

cgilmour commented 7 months ago

Hi @xpdable thanks for the work on contributing this. I like the idea and most of the implementation details. If it's OK, I'll merge this and then make additional changes before including it in a release. That'll make sure you're recognized for the contribution, and soon after the feature will be tested more thoroughly and included in a release.

xpdable commented 6 months ago

@cgilmour Thanks for your information. I do agree with you. My code only covers the happy path and it would be great you admit it and it would be definitely mandatory to setup more boundaries of param checking and tests of this snippet. Thanks. Xiaopeng