DataDog / kong-plugin-ddtrace

Datadog APM Plugin for Kong Gateway
Apache License 2.0
15 stars 7 forks source link

Configure Environment and Service name using Kong Secrets Manager #24

Closed mfischler closed 3 months ago

mfischler commented 6 months ago

Version of kong: 3.5.0 Platform: kubernetes ddtrace version: 0.1.2-1 Configuration Type: Global Configuration Details:

{ "instance_name": null, "enabled": true, "updated_at": 1704398691, "route": null, "created_at": 1704398691, "id": "8bba4f3d-7c08-5dc7-a4e7-e77d6cf58e12", "tags": null, "consumer": null, "config": { "resource_name_rule": null, "static_tags": null, "service_name": "{vault://env-vault/KONG_SERVICE_NAME}", "environment": "{vault://env-vault/KONG_ENVIRONMENT}", "initial_sample_rate": null, "agent_endpoint": "{vault://env-vault/KONG_DATADOG_AGENT_TRACING_ENDPOINT}", "initial_samples_per_second": 100 }, "service": null, "protocols": [ "grpc", "grpcs", "http", "https" ], "name": "ddtrace" }

Detailed description of the problem, and if known, the expected behavior.

Feature request to allow the Service Name and Environment configurations to be referenced from the Kong Secrets Manager similar to the Agent Endpoint (and Host).

Validation:

Following configuration would be possible:

`config: plugins:

dmehala commented 5 months ago

Hi @mfischler

Thank you for reporting this issue. I wanted to inform you that we recently merged the fix in #27. This solution should address the problem you raised, and it will be included in the upcoming release.