DataDog / kong-plugin-ddtrace

Datadog APM Plugin for Kong Gateway
Apache License 2.0
15 stars 7 forks source link

flaky test #8

Closed dgoffredo closed 11 months ago

dgoffredo commented 11 months ago

main as of this commit:

$ git log | head -1
commit f7cfcd88656e6af64a11f7315f1b4a517bd7d54a

pongo run is sometimes successful:

david@ein:~/src/kong-plugin-ddtrace$ pongo run
[pongo-INFO] auto-starting the test environment, use the 'pongo down' action to stop it
Kong version: 3.2.2

kong-plugin-ddtrace 0.1.1-1 depends on lua >= 5.1 (5.1-1 provided by VM)
kong-plugin-ddtrace 0.1.1-1 depends on lua-resty-http >= 0.11 (0.17.0.beta.1-0 installed)
Stopping after installing dependencies for kong-plugin-ddtrace 0.1.1-1

[==========] Running tests from scanned files.
[----------] Global test environment setup.
[----------] Running tests from /kong-plugin/spec/01_span_spec.lua
[ RUN      ] /kong-plugin/spec/01_span_spec.lua @ 6: span starts a new span
[       OK ] /kong-plugin/spec/01_span_spec.lua @ 6: span starts a new span (0.13 ms)
[ RUN      ] /kong-plugin/spec/01_span_spec.lua @ 18: span starts a new span for an existing trace
[       OK ] /kong-plugin/spec/01_span_spec.lua @ 18: span starts a new span for an existing trace (0.10 ms)
[ RUN      ] /kong-plugin/spec/01_span_spec.lua @ 32: span starts a child span
[       OK ] /kong-plugin/spec/01_span_spec.lua @ 32: span starts a child span (0.15 ms)
[ RUN      ] /kong-plugin/spec/01_span_spec.lua @ 48: span sets tags
[       OK ] /kong-plugin/spec/01_span_spec.lua @ 48: span sets tags (0.07 ms)
[----------] 4 tests from /kong-plugin/spec/01_span_spec.lua (1.08 ms total)

[----------] Running tests from /kong-plugin/spec/02_sampler_spec.lua
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 5: trace sampler is created with initial limits
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 5: trace sampler is created with initial limits (0.08 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 16: trace sampler applies the limits  
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 16: trace sampler applies the limits   (0.84 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 42: trace sampler applies the rate to the limit
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 42: trace sampler applies the rate to the limit (0.33 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 76: trace sampler updates the effective rate
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 76: trace sampler updates the effective rate (0.12 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 92: trace sampler uses agent rates when zero permitted by limiter config
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 92: trace sampler uses agent rates when zero permitted by limiter config (0.11 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 101: trace sampler applies rate supplied by the agent
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 101: trace sampler applies rate supplied by the agent (0.07 ms)
[----------] 6 tests from /kong-plugin/spec/02_sampler_spec.lua (2.45 ms total)

[----------] Running tests from /kong-plugin/spec/03_propagation_spec.lua
[ RUN      ] /kong-plugin/spec/03_propagation_spec.lua @ 5: trace propagation extracts an existing trace
[       OK ] /kong-plugin/spec/03_propagation_spec.lua @ 5: trace propagation extracts an existing trace (0.06 ms)
[ RUN      ] /kong-plugin/spec/03_propagation_spec.lua @ 19: trace propagation injects the trace into headers
[       OK ] /kong-plugin/spec/03_propagation_spec.lua @ 19: trace propagation injects the trace into headers (0.07 ms)
[----------] 2 tests from /kong-plugin/spec/03_propagation_spec.lua (0.62 ms total)

[----------] Running tests from /kong-plugin/spec/04_agent_writer_spec.lua
[ RUN      ] /kong-plugin/spec/04_agent_writer_spec.lua @ 23: agent_writer adds spans then flushes them
monkeypatched
[       OK ] /kong-plugin/spec/04_agent_writer_spec.lua @ 23: agent_writer adds spans then flushes them (0.17 ms)
[----------] 1 test from /kong-plugin/spec/04_agent_writer_spec.lua (2.50 ms total)

[----------] Global test environment teardown.
[==========] 13 tests from 4 test files ran. (7.22 ms total)
[  PASSED  ] 13 tests.

and sometimes fails:

david@ein:~/src/kong-plugin-ddtrace$ pongo run
[pongo-INFO] auto-starting the test environment, use the 'pongo down' action to stop it
Kong version: 3.2.2

kong-plugin-ddtrace 0.1.1-1 depends on lua >= 5.1 (5.1-1 provided by VM)
kong-plugin-ddtrace 0.1.1-1 depends on lua-resty-http >= 0.11 (0.17.0.beta.1-0 installed)
Stopping after installing dependencies for kong-plugin-ddtrace 0.1.1-1

[==========] Running tests from scanned files.
[----------] Global test environment setup.
[----------] Running tests from /kong-plugin/spec/01_span_spec.lua
[ RUN      ] /kong-plugin/spec/01_span_spec.lua @ 6: span starts a new span
[       OK ] /kong-plugin/spec/01_span_spec.lua @ 6: span starts a new span (0.15 ms)
[ RUN      ] /kong-plugin/spec/01_span_spec.lua @ 18: span starts a new span for an existing trace
[       OK ] /kong-plugin/spec/01_span_spec.lua @ 18: span starts a new span for an existing trace (0.14 ms)
[ RUN      ] /kong-plugin/spec/01_span_spec.lua @ 32: span starts a child span
[       OK ] /kong-plugin/spec/01_span_spec.lua @ 32: span starts a child span (0.15 ms)
[ RUN      ] /kong-plugin/spec/01_span_spec.lua @ 48: span sets tags
[       OK ] /kong-plugin/spec/01_span_spec.lua @ 48: span sets tags (0.07 ms)
[----------] 4 tests from /kong-plugin/spec/01_span_spec.lua (1.10 ms total)

[----------] Running tests from /kong-plugin/spec/02_sampler_spec.lua
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 5: trace sampler is created with initial limits
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 5: trace sampler is created with initial limits (0.14 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 16: trace sampler applies the limits  
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 16: trace sampler applies the limits   (0.62 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 42: trace sampler applies the rate to the limit
/kong-plugin/spec/02_sampler_spec.lua:72: Expected objects to be equal.
Passed in:
(number) 4
Expected:
(number) 3

stack traceback:
    /kong-plugin/spec/02_sampler_spec.lua:72: in function </kong-plugin/spec/02_sampler_spec.lua:42>

[  FAILED  ] /kong-plugin/spec/02_sampler_spec.lua @ 42: trace sampler applies the rate to the limit (0.28 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 76: trace sampler updates the effective rate
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 76: trace sampler updates the effective rate (0.11 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 92: trace sampler uses agent rates when zero permitted by limiter config
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 92: trace sampler uses agent rates when zero permitted by limiter config (0.06 ms)
[ RUN      ] /kong-plugin/spec/02_sampler_spec.lua @ 101: trace sampler applies rate supplied by the agent
[       OK ] /kong-plugin/spec/02_sampler_spec.lua @ 101: trace sampler applies rate supplied by the agent (0.05 ms)
[----------] 6 tests from /kong-plugin/spec/02_sampler_spec.lua (2.36 ms total)

[----------] Running tests from /kong-plugin/spec/03_propagation_spec.lua
[ RUN      ] /kong-plugin/spec/03_propagation_spec.lua @ 5: trace propagation extracts an existing trace
[       OK ] /kong-plugin/spec/03_propagation_spec.lua @ 5: trace propagation extracts an existing trace (0.07 ms)
[ RUN      ] /kong-plugin/spec/03_propagation_spec.lua @ 19: trace propagation injects the trace into headers
[       OK ] /kong-plugin/spec/03_propagation_spec.lua @ 19: trace propagation injects the trace into headers (0.09 ms)
[----------] 2 tests from /kong-plugin/spec/03_propagation_spec.lua (0.70 ms total)

[----------] Running tests from /kong-plugin/spec/04_agent_writer_spec.lua
[ RUN      ] /kong-plugin/spec/04_agent_writer_spec.lua @ 23: agent_writer adds spans then flushes them
monkeypatched
[       OK ] /kong-plugin/spec/04_agent_writer_spec.lua @ 23: agent_writer adds spans then flushes them (0.24 ms)
[----------] 1 test from /kong-plugin/spec/04_agent_writer_spec.lua (2.59 ms total)

[----------] Global test environment teardown.
[==========] 13 tests from 4 test files ran. (7.44 ms total)
[  PASSED  ] 12 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] /kong-plugin/spec/02_sampler_spec.lua @ 42: trace sampler applies the rate to the limit

 1 FAILED TEST
david@ein:~/src/kong-plugin-ddtrace$