search

DataONEorg / hashstore

HashStore, a hash-based object store for DataONE data packages
Apache License 2.0
1 stars 1 forks source link

Refactor `find_object` to return 'None' #81

Closed doulikecookiedough closed 6 months ago

doulikecookiedough commented 6 months ago

In the current flow, calling find_object on an object that does not exist (missing a pid references file) will raise an exception. Intuitively, this does not make sense because there is no expectation to re-try when a 'FileNotFoundException' is thrown.

Additionally, refactor the hashstoreclient for the most recent changes to ensure testing with knbvm (test.arcticdata.io) works as expected.

doulikecookiedough commented 6 months ago

After attempting to make changes first in HashStore-java to ensure consistency, it does not feel "good" to work with/catch/handle null values which will create confusion as to the actual cause of an exception/issue. I have decided not to proceed with this issue.