Closed doulikecookiedough closed 4 days ago
Thanks again @artntek for your review! I've made the updates in another branch and merged them into develop. I'm also going to hold off on the 1.1.0 release until the changes to deleteObject
are implemented (and merged into develop). I will ping you again then to wrap this PR up.
Greetings @jeanetteclark! When you have scope, can you please help review/perform a sanity check on HashStore?
Additional Changes Since Matthew's Review:
delete_object
functionality & scope
cid
)tag_object
flow with additional locks
Conditions
Summary of Changes:
cid
and creating reference filespid
reference file that contains thecid
, and acid
reference file that containspid
s that reference acid
tag_object
to create the reference files (else create an orphaned object), and optionallydelete_if_invalid_object
should they have data they want to validate theobject_metadata
returned from storing an object.pid+format_id
and in a directory formed using the hash of the pid in/metadata
tag_object
,delete_if_invalid_object
hashstore
config file is now separated in two pieces, with the actual .yaml content being formed with a librarypoetry install
sphinx-autodocumentation
along with typehintsREADME.md
to provide context to the HashStore library and how-to sections.Greetings @artntek - When you have scope, can you please help review
HashStore
to assist me in releasingHashStore 1.1.0
? Please do not hesitate to scrutinize any of the code or bring to my attention any concerns. Thank you 🙏!