Closed doulikecookiedough closed 5 months ago
Optimizations to be made after reviewing with Jing (HashStore-java)
Part 1: Refactor find_object to throw relevant exceptions for the following scenarios:
find_object
Part 2: Update delete_object
delete_object
Part 3: Change ObjectMetadata's id attribute to be 'cid' to be explicit about what it represents
Part 4: Update verify_object return value
verify_object
Part 5: Add new overload method for delete_object
Part 6: Do not throw exceptions when calling delete_sysmeta on a metadata document that does not exist.
delete_sysmeta
Part 7: Confirm that an exception is not thrown when called storing an object that already exists
These items along with Matthew's feedback have been made and merged into develop via Feature-85: Code Review Optimizations
Optimizations to be made after reviewing with Jing (HashStore-java)
Part 1: Refactor
find_object
to throw relevant exceptions for the following scenarios:Part 2: Update
delete_object
delete_object
to handle customized exceptions abovePart 3: Change ObjectMetadata's id attribute to be 'cid' to be explicit about what it represents
Part 4: Update
verify_object
return valuePart 5: Add new overload method fordelete_object
When storing only data, if the data turns out to be invalid (because of a mismatched size or checksum), we need a method to delete the data only.delete_object
Part 6: Do not throw exceptions when calling
delete_sysmeta
on a metadata document that does not exist.Part 7: Confirm that an exception is not thrown when called storing an object that already exists