DataONEorg / hashstore

HashStore, a hash-based object store for DataONE data packages
Apache License 2.0
1 stars 1 forks source link

Code Review Changes #85

Closed doulikecookiedough closed 5 months ago

doulikecookiedough commented 5 months ago

Optimizations to be made after reviewing with Jing (HashStore-java)

Part 1: Refactor find_object to throw relevant exceptions for the following scenarios:

Part 2: Update delete_object

Part 3: Change ObjectMetadata's id attribute to be 'cid' to be explicit about what it represents

Part 4: Update verify_object return value

Part 5: Add new overload method for delete_object

Part 6: Do not throw exceptions when calling delete_sysmeta on a metadata document that does not exist.

Part 7: Confirm that an exception is not thrown when called storing an object that already exists

doulikecookiedough commented 5 months ago

These items along with Matthew's feedback have been made and merged into develop via Feature-85: Code Review Optimizations