search

Daveiano / weewx-wdc

Weather Data Center skin for WeeWX
https://www.weewx-hbt.de/
GNU General Public License v3.0
48 stars 14 forks source link

[BUG] Full screen graphs not working in mobile version #269

Open aryiu opened 7 months ago

aryiu commented 7 months ago

Describe the bug When you open WDC on the phone version, the full screen button in graphs is not working (Safari on iOS). I don't know if it's the expected behaviour of the Carbon components.

To Reproduce Steps to reproduce the behavior:

  1. Go to a graph in mobile version.
  2. Click on the full screen button.
  3. It doesn't do anything.

Expected behavior When tapping on the full screen button, it should open the graph in full screen.

Additional context https://carbondesignsystem.com/data-visualization/simple-charts/

Daveiano commented 1 week ago

@aryiu Are you using Safari on iOS?

aryiu commented 1 week ago

@Daveiano Yes, as I said.

Daveiano commented 3 days ago

@Daveiano Yes, as I said.

Sorry, I completely missed that.

I did not know this yet but Safari (or I think iOS in general) does not support the Fullscreen API all other modern browsers support which I am using for the fullscreen feature.

I don't know of an easy way to implement a full-screen feature on iOS and I am afraid I will not put any time into that. Even the examples at https://carbondesignsystem.com/data-visualization/simple-charts/ do not have a fullscreen icon when accessed by an iPhone.

Sorry to say that