David-Rushton / morello.markdown

A .NET library that pretty prints markdown in the console
MIT License
2 stars 0 forks source link

Refactors AnisRenderer #34

Closed David-Rushton closed 2 years ago

David-Rushton commented 2 years ago

Issues

  1. AnsiRenderer is hard to read, as it spans too many lines
  2. It does not support embedded inlines
  3. It does not support the full CommonMark spec, including:
    • 33

    • 31

    • 29

    • 28

    • 27

AC

EDIT See revised A/C below.

CommonMark spec

As far as I know our markdown parser supports the full spec. So we should be able to meet this goal. However if I am wrong we should still make a best effort. Any types not supported should be rendered as plain text.

cloudflare-workers-and-pages[bot] commented 2 years ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7060b97
Status: ✅  Deploy successful!
Preview URL: https://548dd5d7.morello-markdown.pages.dev
Branch Preview URL: https://dr-remove-throws-from-ansi-r.morello-markdown.pages.dev

View logs

David-Rushton commented 2 years ago

Plan:

David-Rushton commented 2 years ago

This PR fails to build. Because AnsiRenderer tries to detect the console width. At the point it does this there is no console attached.

David-Rushton commented 2 years ago

Revised AC

Descoped items will return in a future PR.