Closed David-Rushton closed 2 years ago
Latest commit: |
7060b97
|
Status: | ✅ Deploy successful! |
Preview URL: | https://548dd5d7.morello-markdown.pages.dev |
Branch Preview URL: | https://dr-remove-throws-from-ansi-r.morello-markdown.pages.dev |
Plan:
This PR fails to build. Because AnsiRenderer
tries to detect the console width. At the point it does this there is no console attached.
AnsiRenderer
should be broken in separate classes and/or filesAnsiRenderer
should support full CommonMark spec~AnsiRenderer
should be best effort
AnsiRenderer
should collect warnings and errors as it progresses~MarkdownConsole
should expose/return warnings and errors~Descoped items will return in a future PR.
Issues
AnsiRenderer
is hard to read, as it spans too many lines33
31
29
28
27
AC
AnsiRenderer
should be broken in separate classes and/or filesAnsiRenderer
should support full CommonMark specAnsiRenderer
should be best effortAnsiRenderer
should collect warnings and errors as it progressesMarkdownConsole
should expose/return warnings and errorsEDIT See revised A/C below.
CommonMark spec
As far as I know our markdown parser supports the full spec. So we should be able to meet this goal. However if I am wrong we should still make a best effort. Any types not supported should be rendered as plain text.