search

DavyJonesLocker / ember-cli-test-interactions

Ember acceptance test helpers.
MIT License
3 stars 0 forks source link

Reorganize file structure #7

Open rsocci opened 8 years ago

rsocci commented 8 years ago

Currently, we have to test helper files: helpers/interactions.js and helpers/finders.js

Goal: Break up interactions.js into multiple files so that we have more specific groups of test helper files

Example:

michaeldupuisjr commented 8 years ago

I think breaking finders into a separate file makes sense, but I think breaking the interactions into the event type ("click" vs "fill in") might be too specific. It might not be intuitive when to create a dedicated file vs adding to an existing one (for example, if we want an interaction for selectFromDropdown(), would that be in the clickers.js or would we create a new select-based file?

This library is kind of based off of capybara-extensions, which breaks "nodes" down as follows: https://github.com/jnicklas/capybara/tree/55c2ec354276ad1a6f0376dd787f5d121117269b/lib/capybara/node

Thoughts?