Open nedpals opened 2 years ago
This is quite an interesting issue.
hi @nedpals can provide the topBar
and title
string.
I can confirm that this test works on iterm2
hi @nedpals can provide the
topBar
andtitle
string.
here are the values (i'll just paste them as []rune as turning them to strings might lose info)
topBar := string([]rune{9484, 32, 66, 111, 120, 32, 32, 32, 32, 32, 67, 76, 73, 32, 32, 32, 32, 32, 77, 97, 107, 101, 114, 32, 32, 32, 128230, 32, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9472, 9488})
title := string([]rune{66, 111, 120, 32, 32, 32, 67, 76, 73, 32, 32, 32, 32, 32, 77, 97, 107, 101, 114, 32, 32, 32, 128230})
there are runes
is after call color.ClearCode()
?
can provide them on before call func ClearCode()
there are
runes
is after callcolor.ClearCode()
? can provide them on before call funcClearCode()
There are the runes
before ClearCode
function call.
color.ClearCode(topBar)
has []rune{66, 111, 120, 32, 32, 32, 32, 32, 67, 76, 73, 32, 32, 32, 32, 32, 77, 97, 107, 101, 114, 32, 32, 32, 128230}
color.ClearCode(title)
has []rune{66, 111, 120, 32, 32, 32, 67, 76, 73, 32, 32, 32, 32, 32, 77, 97, 107, 101, 114, 32, 32, 32, 128230}
@inhere Can you work on solving this?
@Delta456 xstrings.ExpandTabs
maybe has error
see:
@Delta456
xstrings.ExpandTabs
maybe has errorsee:
This seems to work on iterm2
and the rest terminals except iterm
. Can you check what should be the tab size for iterm
? I will add a workaround for it.
hi @Delta456 I am running the test directly in MacOS GoLand
hi @Delta456 I am running the test directly in MacOS GoLand
I see. I really wonder why it fails on iterm
.
I don't think you can even run iterm
in the newer versions of MacOS. Couldn't repro this issue in MacOS Terminal 2.12.7 or Iterm2 v3.4.16 in MacOS v12.6
Describe the bug When running the test especially on
TestTabWithColorBox
, it crashes (specifically an out-of-bounds crash)To Reproduce Steps to reproduce the behavior:
go test -v .
Expected behavior Successful test
Screenshots / Logs
Versions (please complete the following information, if relevant):
Additional context Debugging the text and the separator in runes shows the following results:
the title text in the topbar in
[]runes
(thecolor.clearCode(topBar)
) is66 111 120 32 32 32 32 32 67 76 73 32 32 32 32 32 77 97 107 101 114 32 32 32 128230
while the separator (thecolor.clearCode(title)
) is66 111 120 32 32 32 67 76 73 32 32 32 32 32 77 97 107 101 114 32 32 32 128230
if you look at it closely on the first set of
32
s the text has 532
s while the separator has only 332
sprobably an issue with the
ClearCode
method