search

DemocracyEarth / ubi

Universal Basic Income token.
225 stars 38 forks source link

Broken link in the smart contract #75

Closed n1c01a5 closed 3 years ago

n1c01a5 commented 3 years ago

The link for ERC20BurnableUpgradeable.sol https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/master/contracts/token/ERC20/ERC20BurnableUpgradeable.sol is broken.

santisiri commented 3 years ago

Where did you find this broken link exactly?

n1c01a5 commented 3 years ago

Here https://github.com/DemocracyEarth/ubi/blob/ce2f76372ed209e4887f869db082b9f173799378/contracts/UBI.sol#L5

santisiri commented 3 years ago

Not anymore in the version in master since all ERC20 functionality was brought upfront straight to the contract for gas optimization. burn() is now present in line 227 for instance: https://github.com/DemocracyEarth/ubi/blob/ce2f76372ed209e4887f869db082b9f173799378/contracts/UBI.sol#L227

As it says on the line below, those have been inlined for the purposes of gas optimization.