DesignSafe-CI / DS-User-Guide

User Guide for DesignSafe
https://www.designsafe-ci.org/user-guide/
0 stars 8 forks source link

fix: long and short titles decoupled #32

Closed wesleyboar closed 5 months ago

wesleyboar commented 5 months ago

Overview

Make long title and short/nav title look coupled (and short/nav title less important).

| before | after | | - | - | | ![before](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/f454a703-ec6a-4d9b-a388-7f55cde08ee3) | ![after](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/e4668754-33c2-4d26-a52f-5255c649359b) | Before me: 1. The navigation had been using short titles, and the pages had been using long titles. 2. The documents were concatenated and navigation changed to match TACC user experience. 3. That caused navigation titles to differ from page titles. 4. A solution was implemented to put long and short titles on the page, so: - User could see the short nav title on the page, to check navigation. - User could see the long title on the page, to know the full name. After me: 5. TACC styles made the short title and long title look less coupled. 6. I changed the markup so I could add CSS to: - visually couple the tiles - make short title be less important After this PR: 7. We will review reverting to the old navigation (step 1).

Related

Changes

Testing

  1. Open all use cases within http://localhost:8000/user-guide/usecases/seismicusecases/.
  2. Verify nav titles (under "Seismic") match small title on each use case.
  3. Open all use cases within http://localhost:8000/user-guide/usecases/windstormsurgeusecases/.
  4. Verify nav titles (under "Wind and Storm Surge") match small title on each use case.

UI

Via Docker

before after
before after
screenshots of all affected Use Cases after change ![Screenshot 2024-06-05 at 11 25 04 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/1a2bac77-a913-4be3-9119-dc429cb040bc) ![Screenshot 2024-06-05 at 11 25 10 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/c8b4bf90-ddea-4cff-997c-f276b968e290) ![Screenshot 2024-06-05 at 11 25 14 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/a6351f76-8d09-4f3f-88a8-2a55a1fa24e8) ![Screenshot 2024-06-05 at 11 25 18 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/0046c46b-b5dc-4fbf-b603-bda030b65dc7) ![Screenshot 2024-06-05 at 11 25 21 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/a7cc418f-de19-4dc2-bce8-0b8a2fd51bee) ![Screenshot 2024-06-05 at 11 25 25 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/2d071a96-a6dd-4c38-9e9a-cc6de3a91c88) ![Screenshot 2024-06-05 at 11 25 30 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/3bdeece6-7093-46de-9e78-58421cd1a933) ![Screenshot 2024-06-05 at 11 25 33 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/51d89ebc-1b8a-43db-a746-bc00efa77284) ![Screenshot 2024-06-05 at 11 25 37 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/7fc6243e-217b-4591-9d43-c11de311058f) ![Screenshot 2024-06-05 at 11 25 42 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/c886ecc0-57cd-4c4c-a592-6ae805d59810) ![Screenshot 2024-06-05 at 11 25 45 AM](https://github.com/DesignSafe-CI/DS-User-Guide/assets/62723358/f08ee3d1-db81-4f85-be07-d6ad0228659e)

Via Python

before after
before after
wesleyboar commented 5 months ago

I was verbally given blind trust approval from silviamazzoni for this change.

Her faith is not misplaced. I double checked and fixed non-Docker styles.

Now I merge.