search

DesignSafe-CI / DS-User-Guide

User Guide for DesignSafe
https://www.designsafe-ci.org/user-guide/
0 stars 7 forks source link

silvia/use-cases: suggestions in bulk #40

Closed wesleyboar closed 3 weeks ago

wesleyboar commented 3 weeks ago

Overview

If suggestions through GitHub are not a suitable medium for the contributor.

Related

Changes

Testing & UI

user-guide/docs/usecases/padgett/usecase_JN_viz.md

with <br/>
has no effect		 sans <br/>
renders the same
usecase_JN_viz with br (has no effect) usecase_JN_viz sans br (renders the same)

user-guide/docs/usecases/vantassel_and_zhang/usecase.md

before after
vantassel_and_zhang BEFORE vantassel_and_zhang AFTER
wesleyboar commented 3 weeks ago

@silviamazzoni, if you would rather see all my suggestions and testing for #37 in bulk, see this PR.

silviamazzoni commented 3 weeks ago

your fixes are beautiful.

silviamazzoni commented 3 weeks ago

what does "Squash and merge" mean? it's an option in the green button

wesleyboar commented 3 weeks ago

TL;DR: You'll see a commit "silvia/use-cases: suggestions in bulk (#40)" in your branch's commits instead of "silvia/use-cases: suggestions in bulk […]" (and other commits, had I made any) from this branch's commits.

It is moot merge behavior for this PR, because I only made one commit.

All commits in this branch `silvia/use-cases--suggestions-in-bulk` are merged into the target branch `silvia/use-cases` as a single commit. This makes it so that commits in `silvia/use-cases` are not "polluted" by extraneous history of all the commits in `silvia/use-cases--suggestions-in-bulk`. You may read GitHub's article on the feature, "[Squashing your merge commits](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/about-merge-methods-on-github#squashing-your-merge-commits)".