Dev-tanay / Rubik-Cube

Rubik Cube
https://dev-tanay.github.io/Rubik-Cube/
MIT License
100 stars 157 forks source link

Added the Panaromic Camera Angle. Fixes #140 #170

Open ritankarsaha opened 1 month ago

ritankarsaha commented 1 month ago

Description

This PR fixes the issue #140 raised by me - Ritankar Saha thereby successfully integrating a new camera angle - Panaromic Camera Angle to the Project.

Fixes: #140

Type of change

Checklist:

Screenshot 2024-05-24 at 1 49 46 AM
github-actions[bot] commented 1 month ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

ritankarsaha commented 1 month ago

I have fixed the issue #140 opened by me thereby adding a new camera angle - Panaromic Camera Angle to the project and also raised a PR for the same #170

Dev-tanay commented 4 weeks ago

Please attach a video of your changes @ritankarsaha

ritankarsaha commented 4 weeks ago

@Dev-tanay I am sorry but i have rebased the codebase on my desktop with the main branch, rendering it's changes as the PR was 2 weeks old and i thought the repo went dead. I don't have the codebase on my desktop now owing to it getting rebased with the main branch. I ensure you all the changes are rendered correctly, I have previously worked on this codebase as well fixing 2 issues handling authentication measures. Please review the code, the changes are quite clear and have been commented as well for better understanding. Thank You.