search

Devin0xFFFFFF / singed-feathers

Singed Feathers Game
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

111 show tile heat #149

Closed SashaG-T closed 7 years ago

SashaG-T commented 7 years ago

I think I got all the tabs out? But here it is.

SashaG-T commented 7 years ago

Oh I just found a useless variable declaration. I'll be removing it.

SashaG-T commented 7 years ago

Okay, thanks @MuCephei. I do agree that the TileView should be in control of it's own appearance. When I first started working on this issue I had originally thought that we wanted the TileView to contain as little logic as possible. A few of the stuff mentioned above was an attempt to keep it in the TileController. I know the other day you requested that the TileView be in control of it's own appearance, I just had this pretty much already and wanted to get feedback.

But now that we want it in the TileView, perhaps it would be best to delete this branch and start again? I believe that would be fastest to move the logic over.

SashaG-T commented 7 years ago

I have made my changes that Garrett has requested. @MuCephei Let me know if this is more what you had in mind.