Range selection comment component does not detect when a response has been selected

Devographics / Monorepo

Monorepo containing the State of JS apps

surveyform-sigma.vercel.app

Other

127 stars 52 forks source link

Range selection comment component does not detect when a response has been selected #311

Closed rotan-hanrahan closed 10 months ago

rotan-hanrahan commented 1 year ago

In the "how do you divide your time..." question we are presented with a scale (100% HTML on left, 100% JS on the right). If you find that you want to comment on this scale before actually selecting one of the 9 possible options you can click the comment box, and the box will say "You didn't pick any response. Tell us why:"

However, if you then go back and pick one of the 9 options, the comment stays there falsely accusing you of not picking any response.

false-accusation

eric-burel commented 1 year ago

Might be kinda related to https://github.com/Devographics/Monorepo/issues/290

eric-burel commented 10 months ago

Will be fixed in next release, thanks for catching this out. Numbers are not considered truthy by lodash "isEmpty" somehow so we needed an additional check.