Closed eric-burel closed 9 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
charts | ❌ Failed (Inspect) | Sep 26, 2023 4:41pm |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/devographics-static/deploys/651309bdceddfe00082d4643 |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/stateofjs/deploys/651309bd08c66200084f36ac |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/state-of-graphql/deploys/651309bd01cb9f000869db7b |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/stateofjs2022/deploys/651309bdd2e8f40008c5387e |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/graphiql-devographics/deploys/651309bdcb98150008315c64 |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/devographics-graphiql2/deploys/651309bdaf1af40009014f9f |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/stateofcss/deploys/651309bd1412b40008e7fd8c |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/css2023/deploys/651309bd2efe880008fdc217 |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/tokyodev2022/deploys/651309bdf55b3200085a1ccf |
Name | Link |
---|---|
Latest commit | 6015fb6caa35806a90dad934a66f93c13e80ed7e |
Latest deploy log | https://app.netlify.com/sites/devographics-graphiql-internal/deploys/651309bda5665100087a4b39 |
Your build failed. View the build logs.
Your build failed. View the build logs.
Your build failed. View the build logs.
Your build failed. View the build logs.
Test: I am pressing a button of the slider, and check if the radiogroup below "Bonheur général" is also rerendered
Before (all stuff in color rerender):
After (all stuff in grey do not rerender => formLayout):
I could remove some rerenders but cutting the Form context more correctly between values that do not move (context is only used in order to avoid props drilling), values that moves (response state) and actions (updating a value, but not depending on the current global values). I've also used memo on the Radiogroup.
The problem I hit is that
FormItem
is too generic, and therefore require a lot of data. For instance, it uses the response to check for a dynamic pathcommentPath
=> that's no good, because it means you need to wholeresponse
to access onlyresponse[commentPath]
, but I can't really get around that yet.We should try to avoid doing to much in the FormItem and perhaps move this kind logic to a callback passed by the parent, or some global context or whatever.
At least this PR cleans the code a little and opens room for more future optimizations.
Oh yeah and this has no impact on #237 (radiogroup on Firefox), probably because the radio still rerender.