search

Devographics / Monorepo

Monorepo containing the State of JS apps
surveyform-sigma.vercel.app
Other
119 stars 50 forks source link

Feature/remove react i18n #357

Closed eric-burel closed 3 months ago

eric-burel commented 5 months ago

@SachaG I've started investigating moving the locale fetching functions of results towards shared, but beforehand I needed to move everything to TS to get a better view of the data structure

The thing is that surveyform uses shared logic that is more mature but uses specific locale structure, while results uses specific logic to fetching from Redis and API, but with the structure we want, I need to type these structures

As expected, it doesn't work yet the results app won't run with the TS files... but I am getting closer you might want to take a look at the error messages

netlify[bot] commented 5 months ago

Deploy Preview for devographics-static failed.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/devographics-static/deploys/65c3ec879659350008913bf7
netlify[bot] commented 5 months ago

Deploy Preview for stateofjs canceled.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/stateofjs/deploys/65c3ec87c940520008302c2a
netlify[bot] commented 5 months ago

Deploy Preview for stateofcss canceled.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/stateofcss/deploys/65c3ec87f25a080008c75498
netlify[bot] commented 5 months ago

Deploy Preview for css2023 failed.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/css2023/deploys/65c3ec87f25a080008c7549d
render[bot] commented 5 months ago

Your Render PR Server URL is https://tokyodev-surveyform-pr-357.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cmjv2k8l5elc73am9e10.

netlify[bot] commented 5 months ago

Deploy Preview for devographics-graphiql2 canceled.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/devographics-graphiql2/deploys/65c3ec87425ae80008997825
netlify[bot] commented 5 months ago

Deploy Preview for tokyodev2022 failed.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/tokyodev2022/deploys/65c3ec8719d02f00089be31c
netlify[bot] commented 5 months ago

Deploy Preview for state-of-graphql canceled.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/state-of-graphql/deploys/65c3ec87fdb84d00094c6d1f
netlify[bot] commented 5 months ago

Deploy Preview for graphiql-devographics canceled.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/graphiql-devographics/deploys/65c3ec878da8e50008dc3cc5
netlify[bot] commented 5 months ago

Deploy Preview for stateofjs2022 failed.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/stateofjs2022/deploys/65c3ec87fb1b2a000892d4a8
netlify[bot] commented 5 months ago

Deploy Preview for devographics-graphiql-internal canceled.

Name Link
Latest commit 900c95a0d8ad8fbe367efa06271f7de6a0c4779b
Latest deploy log https://app.netlify.com/sites/devographics-graphiql-internal/deploys/65c3ec87fec3c100087adb12
vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
charts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 8:49pm
eric-burel commented 5 months ago

@SachaG for now I am stuck with https://github.com/gatsbyjs/gatsby/discussions/34613#discussioncomment-8400023 We can't import shared code in gatsby-node which prevents refactoring of the function that fetches the locale I'll wait for an answer but if it doesn't work, I'll just rollback, and copy-paste the code into Gatsby...

julianCast commented 2 months ago

@SachaG for now I am stuck with gatsbyjs/gatsby#34613 (comment) We can't import shared code in gatsby-node which prevents refactoring of the function that fetches the locale I'll wait for an answer but if it doesn't work, I'll just rollback, and copy-paste the code into Gatsby...

Same issue, did you find a solution?

eric-burel commented 2 months ago

We are currently moving to Astro, not being able to use TypeScript in shared code is quite painful If you need a palliative solution, you can reintroduce a build system in your shared code with whatever tools works best. We previously used Tsup but Bun has a good reputation these days.